Skip to content

esm: fix chain advances when loader calls next<HookName> multiple times#43303

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
JakobJingleheimer:esm/fix-multiple-next-calls-advancing-chain
Jun 5, 2022
Merged

esm: fix chain advances when loader calls next<HookName> multiple times#43303
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
JakobJingleheimer:esm/fix-multiple-next-calls-advancing-chain

Conversation

@JakobJingleheimer
Copy link
Copy Markdown
Member

@JakobJingleheimer JakobJingleheimer commented Jun 2, 2022

fixes #43238

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@aduh95 aduh95 aduh95 approved these changes

@guybedford guybedford Awaiting requested review from guybedford

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

esm custom loader: multiple calls to nextHook within the same loader result in different nextHooks

7 participants

@JakobJingleheimer @nodejs-github-bot @tniessen @Trott @aduh95 @ljharb @GeoffreyBooth